Skip to content

Add HautelookAliceBundle mention #5773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

theofidry
Copy link
Contributor

Q A
Doc fix? no
New docs? no
Applies to 2.3+

HautelookAliceBundle is a bundle for Faker and Alice so the integration might be easier than using the two libraries.

@xabbuh
Copy link
Member

xabbuh commented Oct 10, 2015

Thank you for proposing this change @theofidry. However, there are also bundles to integrate faker (like https://github.com/willdurand/BazingaFakerBundle). Should we mention them here too?

@theofidry
Copy link
Contributor Author

Obviously we can't mention them all:

Plus the bundles for Faker... However the three most popular in the order is DoctrineFixturesBundle (no longer active), HautelookAliceBundle and BazingaFakerBundle.

But that's just a proposal, if you feel it wouldn't be fair to other bundles well at least I would have tried :)

@dupuchba
Copy link

👍 for mentioning them all but don't forget that when there is too much choices, people get lost :-). Maybe it would be useful to suggest one/two well proofed library.

@theofidry
Copy link
Contributor Author

The issue there is that there is yet to be a consensus on the choice of the bundle. To me they all look redundant and I've been a long time frustrated by how things were not moving before rewriting HautelookAliceBundle.

@stof
Copy link
Member

stof commented Oct 14, 2015

DoctrineFixturesBundle does not integrate Alice nor Faker (you can use them inside your doctrine fixtures though)

@theofidry
Copy link
Contributor Author

@stof true, but it was more about having advanced fixtures rather than actually using Alice and Faker.

@javiereguiluz
Copy link
Member

I like the idea of mentioning only one bundle to integrate Alice/Faker. We should choose the best one according to our criteria. If we can't reach an agreement, let's mention two bundles.

I'd even reword the original message. Instead this:

Consider using `Faker`_, `Alice`_ or `HautelookAliceBundle`_ libraries to generate
real-looking data [...]

We could say something like:

Consider using `HautelookAliceBundle`_ to generate real-looking data for your fixtures.
This bundle integrates the `Faker`_ and `Alice`_ libraries [...]

@@ -113,7 +113,7 @@ pure JavaScript-based testing tools.
Learn More about Functional Tests
---------------------------------

Consider using `Faker`_ and `Alice`_ libraries to generate real-looking data
Consider using `Faker`_, `Alice`_ or `HautelookAliceBundle`_ libraries to generate real-looking data
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not a library, its a bundle.

@wouterj
Copy link
Member

wouterj commented Dec 19, 2015

Hi @theofidry, thanks for starting this pull request. I've taken your commit and applied @javiereguiluz's comment and put both commits in a new PR: #6051 Although I close this PR, you'll still get the credits for this suggestion.

Have a nice weekend! 🎄

@wouterj wouterj closed this Dec 19, 2015
wouterj added a commit that referenced this pull request Feb 6, 2016
…, WouterJ)

This PR was merged into the 2.3 branch.

Discussion
----------

Mention HautelookAliceBundle in best practices

Finishes #5773

| Q | A
| --- | ---
| Doc fix? | no
| New docs? | yes
| Applies to | all
| Fixed tickets | -

Reasons why I choosed HautelookAliceBundle over h4ccAliceFixturesBundle:
 * It seems more active
 * It supports Symfony 3
 * It supports more database providers

Commits
-------

621336d Rewrite message
b268226 Add HautelookAliceBundle mention
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants